-
Notifications
You must be signed in to change notification settings - Fork 5
DOCSP-56868: Add GET /api/movies/genres endpoint to Java Spring and Python FastAPI backends #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cbullinger
merged 2 commits into
feature/filtering
from
docsp-55528-filtering-java-python
Jan 21, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,10 @@ | |
| Search movies using MongoDB Vector Search to enable semantic search capabilities over | ||
| the plot field. | ||
|
|
||
| - GET /api/movies/genres : | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same Q here - since this is a new route, should we add a test for it in the
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added |
||
| Retrieve all distinct genre values from the movies collection. | ||
| Demonstrates the distinct() operation. | ||
|
|
||
| - GET /api/movies/{id} : | ||
| Retrieve a single movie by its ID. | ||
|
|
||
|
|
@@ -427,6 +431,41 @@ async def vector_search_movies( | |
| detail=f"Error performing vector search: {str(e)}" | ||
| ) | ||
|
|
||
| """ | ||
| GET /api/movies/genres | ||
|
|
||
| Retrieve all distinct genre values from the movies collection. | ||
| Demonstrates the distinct() operation. | ||
|
|
||
| Returns: | ||
| SuccessResponse[List[str]]: A response object containing the list of unique genres, sorted alphabetically. | ||
| """ | ||
|
|
||
| @router.get("/genres", | ||
| response_model=SuccessResponse[List[str]], | ||
| status_code=200, | ||
| summary="Retrieve all distinct genres from the movies collection.") | ||
| async def get_distinct_genres(): | ||
| movies_collection = get_collection("movies") | ||
|
|
||
| try: | ||
| # Use distinct() to get all unique values from the genres array field | ||
| # MongoDB automatically flattens array fields when using distinct() | ||
| genres = await movies_collection.distinct("genres") | ||
| except Exception as e: | ||
| raise HTTPException( | ||
| status_code=500, | ||
| detail=f"Database error occurred: {str(e)}" | ||
| ) | ||
|
|
||
| # Filter out null/empty values and sort alphabetically | ||
| valid_genres = sorted([ | ||
| genre for genre in genres | ||
| if isinstance(genre, str) and len(genre) > 0 | ||
| ]) | ||
|
|
||
| return create_success_response(valid_genres, f"Found {len(valid_genres)} distinct genres") | ||
|
|
||
| """ | ||
| GET /api/movies/{id} | ||
| Retrieve a single movie by its ID. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add tests for this to the
testtarget? Looks like we have bothControllerandServicetests there where we may want to consider adding this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added