DOCSP-47058: Shift TOC #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rustagir
requested changes
May 21, 2025
config/redirects
Outdated
|
|
||
| # comprehensive coverage redirects | ||
| [v2.x-*]: ${prefix}/${version}/aggregation/atlas-search/ -> ${base}/${version}/atlas-search/ |
There was a problem hiding this comment.
Q: are we going to backport the TOC changes as we've done with the other languages? in that case, should you redirect all versions?
There was a problem hiding this comment.
If that's what we've done for the others then yes I'll backport to all for PHP too, fixed!
config/redirects
Outdated
Comment on lines
94
to
95
| [v2.x-*]: ${prefix}/${version}/write/ -> ${base}/${version}/ |
There was a problem hiding this comment.
S: consider redirecting these to the CRUD landing page instead
config/redirects
Outdated
| [v2.x-*]: ${prefix}/${version}/connect/tls/ -> ${base}/${version}/security/tls/ | ||
| [v2.x-*]: ${prefix}/${version}/aggregation/vector-search/ -> ${base}/${version}/vector-search/ | ||
| [v2.x-*]: ${prefix}/${version}/monitoring/ -> ${base}/${version}/ |
There was a problem hiding this comment.
S: consider redirecting to the monitoring-logging.txt landing page
source/crud.txt
Outdated
| Operations with Builders </crud/builders> | ||
|
|
||
| CRUD (Create, Read, Update, Delete) operations enable you to work with | ||
| data stored in MongoDB. |
There was a problem hiding this comment.
S: add a sentence introducing the list
- "Visit the following guides to learn more about performing CRUD operations on the data in your MongoDB collections... etc"
source/crud/bulk-write.txt
Outdated
| @@ -68,7 +68,7 @@ specify the write operations: | |||
| .. tip:: | |||
|
|
|||
| For more information about delete, insert, replace, and update | |||
| operations, see the :ref:`Write operation guides <php-write>`. | |||
| operations, see the :ref:`CRUD <php-crud-operations>` section. | |||
There was a problem hiding this comment.
Suggested change
| operations, see the :ref:`CRUD <php-crud-operations>` section. | |
| operations, see the :ref:`php-crud-operations` guides. |
source/get-started.txt
Outdated
Comment on lines
347
to
348
| - Learn how to perform read and write operations in the :ref:`<php-crud-operations>` section. |
There was a problem hiding this comment.
S: nit - dont need <> brackets when importing the ref title directly
Suggested change
| - Learn how to configure your MongoDB connection in the :ref:`<php-connect>` section. | |
| - Learn how to perform read and write operations in the :ref:`<php-crud-operations>` section. | |
| - Learn how to configure your MongoDB connection in the :ref:`php-connect` section. | |
| - Learn how to perform read and write operations in the :ref:`php-crud-operations` section. |
source/issues-and-help.txt
Outdated
|
|
||
| .. meta:: | ||
| :keywords: php, troubleshooting, feedback | ||
| :description: Find support for the {+library-short+, report bugs or feature requests, and learn how to contribute. |
There was a problem hiding this comment.
Suggested change
| :description: Find support for the {+library-short+, report bugs or feature requests, and learn how to contribute. | |
| :description: Find support for the PHP library, report bugs or feature requests, and learn how to contribute. |
source/issues-and-help.txt
Outdated
|
|
||
| .. note:: | ||
|
|
||
| Bug reports in the PHP Jira project are publicly viewable. |
There was a problem hiding this comment.
Suggested change
| Bug reports in the PHP Jira project are publicly viewable. | |
| Bug reports in the PHPLIB Jira project are publicly viewable. |
rustagir
approved these changes
May 21, 2025
| @@ -21,14 +21,12 @@ toc_landing_pages = [ | |||
| "/reference/class/MongoDBModelDatabaseInfo", | |||
| "/reference/class/MongoDBModelIndexInfo", | |||
| "/connect", | |||
There was a problem hiding this comment.
S: add /connect/connection-options/
source/index.txt
Outdated
| Atlas Vector Search | ||
| ------------------- | ||
|
|
||
| Learn how to run Atlas Vector Search queries in the :ref:`<php-vector-search>` section. | ||
|
|
||
| Optimize Queries with Indexes |
There was a problem hiding this comment.
S: this item is out of order
| Release Notes </references/release-notes> | ||
| Compatibility </references/compatibility> | ||
| Upgrade Guides </references/upgrade> | ||
|
|
There was a problem hiding this comment.
S: add short sentence introducing sub pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47058
Staging Links
Self-Review Checklist