Skip to content

Conversation

@lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Feb 6, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44237
Staging - https://deploy-preview-198--docs-php-library.netlify.app/reference/method/MongoDBDatabase-createCollection/#parameters

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit 2e02b9e
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/67a68e55c0b102000866ccba
😎 Deploy Preview https://deploy-preview-198--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to put so many details on an option that was not documented, that doesn't work with any version of the server supported by the lib, and that is removed in v2?

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things:

  • you should re-create this PR against the v1.21 branch. On this branch, you should edit the API documentation to remove most of the info and just say that this option is deprecated. You do not need to include a version number as the branch is versioned
  • Add a short note to the v1.21 whats new

@lindseymoore lindseymoore requested a review from rustagir February 7, 2025 23:03
@lindseymoore lindseymoore changed the title DOCSP-44237 flags Option deprecated in v2.21 DOCSP-44237 flags Option deprecated Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants