Skip to content

Rename ArrayField.size to max_size #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2025

Conversation

timgraham
Copy link
Collaborator

Vector search indexes need to be a fixed size, so size will be re-added to represent that (#264).

I didn't rename SplitArrayWidget.size, thinking maybe it makes sense to add a separate kwarg like fixed_size=True, but I'm still thinking about the best solution.

@WaVEV
Copy link
Collaborator

WaVEV commented Mar 27, 2025

Vector search indexes need to be a fixed size, so size will be re-added to represent that (#264).

I didn't rename SplitArrayWidget.size, thinking maybe it makes sense to add a separate kwarg like fixed_size=True, but I'm still thinking about the best solution.

If in the future we want to add min size / min length, and maybe we have to refactor and breaks some compatibilities. So, how likely is to add min length in the future given the form supports it?.

@timgraham timgraham requested a review from WaVEV April 4, 2025 14:30
@Jibola
Copy link
Contributor

Jibola commented Apr 4, 2025

Vector search indexes need to be a fixed size, so size will be re-added to represent that (#264).
I didn't rename SplitArrayWidget.size, thinking maybe it makes sense to add a separate kwarg like fixed_size=True, but I'm still thinking about the best solution.

If in the future we want to add min size / min length, and maybe we have to refactor and breaks some compatibilities. So, how likely is to add min length in the future given the form supports it?.

I don't think it'll be likely to add min length. On top of that, at that point the validation should be something user defined.

@timgraham timgraham force-pushed the rename-array-field-size branch from 133c71a to d0ce345 Compare April 8, 2025 00:33
@timgraham timgraham merged commit d0ce345 into mongodb:main Apr 8, 2025
14 checks passed
@timgraham timgraham deleted the rename-array-field-size branch April 8, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants