-
Notifications
You must be signed in to change notification settings - Fork 18
Rename ArrayField.size to max_size #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
75ac89a
to
5c41658
Compare
5c41658
to
a345548
Compare
a345548
to
1c82dbd
Compare
If in the future we want to add min size / min length, and maybe we have to refactor and breaks some compatibilities. So, how likely is to add min length in the future given the form supports it?. |
I don't think it'll be likely to add min length. On top of that, at that point the validation should be something user defined. |
133c71a
to
d0ce345
Compare
Vector search indexes need to be a fixed size, so
size
will be re-added to represent that (#264).I didn't rename
SplitArrayWidget.size
, thinking maybe it makes sense to add a separate kwarg likefixed_size=True
, but I'm still thinking about the best solution.