Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SearchIndex and VectorSearchIndex #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add SearchIndex and VectorSearchIndex #264
Changes from all commits
3bad834
bd8f3fc
a5b6826
f987e7f
ea32d94
01cd73a
d96fdbd
44a6dcd
f6fec5e
d77b6a9
ed25939
1cb3a7e
cf7284e
ffcc0dd
9a50963
028898e
fdc0c39
9fbf6a9
ef3d3c5
59726da
c51b69a
a4a3076
9fe24d5
c456b00
8a08fd9
fc87a80
951795d
4272630
a36d11a
09101a5
01cec0e
0a9771f
cadf68c
985754c
5a19e26
33d1f76
5a81285
dcd22df
d9b1941
8b8e960
926cfbb
db62c59
d0f9927
f784c9a
7dfd5bf
a6ccf88
de09466
6e6043d
75aac72
262069b
731f349
50d9b10
34dc035
10fdf69
56e89a1
feaead9
e0fe059
3ad033b
1d39d32
1cb2d3f
21ba183
9a392e6
2d6b574
debb056
3cbae58
36a9cf6
56e323f
3ccb17e
63d74e7
d7526e4
4ac6a90
a9f0d8b
71d649e
3fa4b81
07dae4c
74b711a
5be8cea
b0d3482
afed7e7
c3b0b4c
cfa9f01
82aa32e
cad0ebf
8dbd0f1
ed97399
c5a45fb
6b84168
80fffa5
0e987fc
69984f9
ad3d6ec
c74604e
b868f59
3596a99
4792689
5fa8fbc
3f43d46
0d6f719
252f364
0f28afe
dcdf271
c59297c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you decide that cosine should be the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, any time that I worked with embedding, this similarity was the first that I tried. Except when the data was normalized (in that case, cosine and dot product gives the same result and dot product is faster). L2 norm is used but less than cosine in semantics searches.
In order to simplify the index, I decided to put cosine in default.
I have no preference to put similarities as a needed parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the Atlas docs, I didn't get the sense that there is a sensible default that works for most situations, but I really don't know, so let's ask the team's opinion on Monday.