Skip to content

RUST-1748 Refactor BSON DateTime serde converters using serde_conv_doc macro #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JamieTsai1024
Copy link
Collaborator

@JamieTsai1024 JamieTsai1024 commented Jul 8, 2025

Refactor all BSON DateTime serde helpers to use serde_conv_doc

Previously:

  • Rewrote serde converters as structs with SerializeAs and DeserializeAs traits to support Optional and Vector conversions in PR #559
  • Refactored struct implementation to use serde_conv macro in PR #566

Additional work required for RUST-1748

  • Refactor remaining serde helpers using serde_conv_doc

@JamieTsai1024 JamieTsai1024 marked this pull request as ready for review July 8, 2025 15:21
@JamieTsai1024 JamieTsai1024 requested a review from a team as a code owner July 8, 2025 15:21
@JamieTsai1024 JamieTsai1024 requested a review from kevinAlbs July 8, 2025 17:37
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I request waiting on @isabelatkinson or @abr-egn to review before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants