Skip to content

RUST-2058 Fix BSON WASM tests #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2025
Merged

RUST-2058 Fix BSON WASM tests #512

merged 2 commits into from
Jan 21, 2025

Conversation

abr-egn
Copy link
Contributor

@abr-egn abr-egn commented Jan 21, 2025

RUST-2058

There were two unrelated issues here:

  • The wasm32-wasi target was renamed in newer versions of rustc to wasm32-wasip1 (to make room for the upcoming wasm32-wasip2), so we need conditional logic for that.
  • The version of LLVM used in rustc 1.82+ emits webassembly using a reference types specification that's not supported in the node.js runtime (this bug has some details). I've pinned that test to rustc 1.81 for now; hopefully by the time our MSRV catches up to that and we need to unpin it node will have also caught up :)

@abr-egn abr-egn marked this pull request as ready for review January 21, 2025 19:15
@abr-egn abr-egn requested a review from kevinAlbs January 21, 2025 19:15
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@abr-egn abr-egn merged commit 04d1549 into mongodb:main Jan 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants