Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide django version check guidance #245

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Conversation

Jibola
Copy link
Collaborator

@Jibola Jibola commented Jan 31, 2025

No description provided.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated

You can check what version of Django you're using with:
```bash
$ pip show django
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of $ django-admin --version is a lot simpler. (However, if they follow the instructions above, I'm not sure how they would get to this point without knowing what version of Django they're using.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also pip install django-mongodb-backend installs the corresponding Django

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's have main be non-specific?

pip install django-mongodb-backend
and then also check the version.

I've checked with some folks adhoc, they have still just done pip install django-mongodb-backend

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not omit the version install advice/qualifiers, since there will be plenty of people who want to add this to an existing project on a particular version of Django. What you wrote is fine for now.

@Jibola Jibola merged commit d85de60 into main Feb 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants