Skip to content

INTPYTHON-663 Skip non-tokenized filter test in langchaingo #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2025
Merged

INTPYTHON-663 Skip non-tokenized filter test in langchaingo #83

merged 3 commits into from
Jul 1, 2025

Conversation

prestonvasquez
Copy link
Contributor

@prestonvasquez prestonvasquez commented Jul 1, 2025 •
edited
Loading

There appears to be a regression in the expected error for non-tokenized filter and the test should now expect the following error:

'pageContent' needs to be indexed as filter

Suggest skipping the failing test for now, deferring the LCG update to GODRIVER-3606.

@blink1073 blink1073 changed the title Skip non-tokenized filter test in langchaingo INTPYTHON-663 Skip non-tokenized filter test in langchaingo Jul 1, 2025
blink1073
blink1073 approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prestonvasquez prestonvasquez merged commit 8ccda91 into mongodb-labs:main Jul 1, 2025
7 of 14 checks passed
@prestonvasquez prestonvasquez deleted the INTPYTHON-663 branch July 1, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestonvasquez @blink1073