GODRIVER-3334 Include LangChainGo in AI/ML integration pipeline #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expansions: | ||
| DIR: langchaingo-golang | ||
| run_on: | ||
| - ubuntu2204-small |
There was a problem hiding this comment.
How come you've changed the host? It was a set and forget thing. Does rhel87-small not have your go version? Should we consider updating all?
There was a problem hiding this comment.
The tests rely on docker, which isn't available on the RHEL hosts.
caseyclements
requested changes
Jan 24, 2025
.evergreen/fetch-repo.sh
Outdated
|
|
||
| # Clone the repository, with an optional branch | ||
| if [ -n "${BRANCH}" ]; then | ||
| git clone --branch "${BRANCH}" "${CLONE_URL}" |
There was a problem hiding this comment.
This doesn't seem necessary. Your CLONE_URL can be arbitrary. For example:
CLONE_URL=" -b PYTHON-4522 --single-branch https://github.com/shruti-sridhar/llama_index.git"
|
LGTM as well pending the cleanup of the git checkout. |
blink1073
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3334
Include langchaingo in the AI/ML integration. Note that the pull request is still under review (see PR #1025). For now, we point to the fork where the pull request is being developed.
Since the langchaingo integration tests use testcontainers, remote / local atlas setup is not necessary.
GODRIVER-3465 was created as a follow-up to update the repo and branch once 3334 is complete.