feat(cli-repl): add configuration to set log location MONGOSH-1983 #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
changed the title
gagik
force-pushed
the
gagik/add-log-location
branch
from
10cb29c to
718990c
Compare
gagik
force-pushed
the
gagik/add-disable-logging
branch
7 times, most recently
from
054080c to
5147039
Compare
gagik
force-pushed
the
gagik/add-log-location
branch
4 times, most recently
from
3060ce3 to
fa404ed
Compare
gagik
changed the title
gagik
force-pushed
the
gagik/add-log-location
branch
from
fa404ed to
b17d60c
Compare
gagik
commented
Jan 27, 2025
addaleax
requested changes
Jan 27, 2025
There was a problem hiding this comment.
This should come with an e2e test that verifies that the file actually gets created and written to (in this section:
mongosh/packages/e2e-tests/test/e2e.spec.ts
Line 1327 in 7e35e10
gagik
force-pushed
the
gagik/add-disable-logging
branch
5 times, most recently
from
1bbbfb0 to
adf5199
Compare
gagik
force-pushed
the
gagik/add-log-location
branch
from
b17d60c to
03cde65
Compare
gagik
force-pushed
the
gagik/add-log-location
branch
from
03cde65 to
b81f660
Compare
gagik
changed the title
gagik
force-pushed
the
gagik/add-disable-logging
branch
3 times, most recently
from
ce7e5b9 to
0ffae4c
Compare
gagik
force-pushed
the
gagik/add-log-location
branch
2 times, most recently
from
2f2937c to
78db84a
Compare
gagik
force-pushed
the
gagik/add-log-location
branch
from
78db84a to
2007b9f
Compare
gagik
force-pushed
the
gagik/add-log-location
branch
from
352ac10 to
ac83260
Compare
addaleax
approved these changes
Feb 6, 2025
alenakhineika
approved these changes
Feb 6, 2025
This reverts commit 85453b9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to configure log location.