Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e-tests): add TestShell#eventually and refactor TestShell#executeLine and TestShell#waitForPrompt #2171

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
+140 −91
Draft

chore(e2e-tests): add TestShell#eventually and refactor TestShell#executeLine and TestShell#waitForPrompt #2171

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c14ba16
Implement and use a TestShell.eventually
kraenhansen Sep 18, 2024
7996261
Fix race in executeLine and waitForPrompt
kraenhansen Sep 18, 2024
f497436
Bump timeout in "e2e Analytics Node" before hook's
kraenhansen Sep 18, 2024
6e690ff
Trim input to writeInputLine
kraenhansen Oct 7, 2024
7d64009
Use eventually to poll for file changes
kraenhansen Oct 7, 2024
11da494
fixup! Implement and use a TestShell.eventually
kraenhansen Oct 8, 2024
8179ade
simplify TestShell#_onClose creation
kraenhansen Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bump timeout in "e2e Analytics Node" before hook's
@kraenhansen
kraenhansen committed Oct 8, 2024

Verified

This commit was signed with the committer’s verified signature.
kraenhansen Kræn Hansen
SSH Key Fingerprint: Pl/0muSeAJtfZzXTskmf7NspKHTlgrI4SZS/qPTQ5Eg
Verified
Learn about vigilant mode
commit f497436d9a45c1d6a52f4953a72ceddd088008ab
2 changes: 1 addition & 1 deletion packages/e2e-tests/test/e2e-analytics.spec.ts
View file
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ describe('e2e Analytics Node', function () {
);
expect(helloIsWritablePrimary).to.contain('true');
},
{ timeout: 20_000 }
{ timeout: 40_000 }
);
});