Skip to content

Conversation

himanshusinghs
Copy link
Collaborator

@himanshusinghs himanshusinghs commented Sep 16, 2025

Proposed changes

VSCode exposes a few MCP properties as configurable properties through extension settings. This PR extends the lib with all the configurable properties that the MCP server can accept so that VSCode can filter out the irrelevant ones and provide only the relevant config.

Checklist

@himanshusinghs himanshusinghs requested a review from a team as a code owner September 16, 2025 12:10
@Copilot Copilot AI review requested due to automatic review settings September 16, 2025 12:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the library to expose configurable properties for VSCode integration by making the ALL_CONFIG_KEYS constant available as a public export.

  • Exports ALL_CONFIG_KEYS as configurableProperties from the main library entry point
  • Makes the ALL_CONFIG_KEYS constant exportable by adding the export keyword

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/lib.ts Adds export of ALL_CONFIG_KEYS as configurableProperties to the public API
src/common/config.ts Makes ALL_CONFIG_KEYS constant exportable by adding export modifier

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@himanshusinghs himanshusinghs merged commit f530123 into main Sep 16, 2025
19 checks passed
@himanshusinghs himanshusinghs deleted the chore/lib-extension branch September 16, 2025 12:18
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17765271882

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 82.097%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/tools/atlas/connect/connectCluster.ts 8 77.22%
Totals Coverage Status
Change from base Build 17764993826: -0.09%
Covered Lines: 5022
Relevant Lines: 6006

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants