chore: Support for proxies for Atlas tools. MCP-87 #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the code is broken because there is some issue with the promise returned by the agent. I'm still investigating it.
This adds support for a custom fetch that can use proxies configured with environment variables.
kmruiz
changed the title
kmruiz
changed the title
Uses a variant devtools-shared/devtools-proxy-support http proxy server for testing.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
node-fetch requires an internal symbol to identify if a request is an object or a string. Because openapi-fetch does not provide this symbol, node-fetch misunderstands the request.
Pull Request Test Coverage Report for Build 16626320664Details
💛 - Coveralls |
fmenezes
reviewed
Jul 30, 2025
| @@ -22,9 +23,10 @@ | |||
| "mongodb-log-writer": "^2.4.1", | |||
| "mongodb-redact": "^1.1.8", | |||
| "mongodb-schema": "^12.6.2", | |||
| "node-fetch": "^3.3.2", | |||
There was a problem hiding this comment.
do we need node-fetch here? my understanding is that we should be using native fetch from v8
There was a problem hiding this comment.
devtools-proxy-support uses node-fetch right now, so sadly we will need to use node-fetch for now. I'm already in conversations with Anna to see when we can drop support for node-fetch in favour of the native fetch from Node.js.
There was a problem hiding this comment.
We will stay with node-fetch for a while, because the native fetch doesn't support agents (necessary for proxying) and it doesn't support natively proxies either (support for HTTP and HTTPs proxies is still experimental and doesn't support socks5).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
To add proxy support I had to do a few more changes than expected.
Also, some relevant info:
Checklist