Skip to content

fix: workaround models not providing arguments when everything is optional #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

nirinchev
Copy link
Collaborator

No description provided.

@nirinchev nirinchev requested review from gagik and fmenezes and removed request for gagik April 24, 2025 15:36
@coveralls
Copy link
Collaborator

coveralls commented Apr 24, 2025

Pull Request Test Coverage Report for Build 14646461085

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 82.01%

Totals Coverage Status
Change from base Build 14646446762: 0.2%
Covered Lines: 692
Relevant Lines: 795

💛 - Coveralls

Copy link
Collaborator

@gagik gagik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can ignore style checks, I'm fixing them in the lint PR coming up

Base automatically changed from ni/logs to main April 24, 2025 16:14

Verified

This commit was signed with the committer’s verified signature.
nirinchev Nikola Irinchev

Verified

This commit was signed with the committer’s verified signature.
nirinchev Nikola Irinchev

Verified

This commit was signed with the committer’s verified signature.
nirinchev Nikola Irinchev
@nirinchev nirinchev merged commit 77513d9 into main Apr 24, 2025
7 checks passed
@nirinchev nirinchev deleted the ni/windsurf branch April 24, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants