Skip to content

chore: add remaining mongodb integration tests #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025
Merged

Conversation

nirinchev
Copy link
Collaborator

Add final set of tests for updateMany, renameCollection, and explain.

@nirinchev nirinchev requested a review from gagik April 23, 2025 21:37
@coveralls
Copy link
Collaborator

coveralls commented Apr 23, 2025

Pull Request Test Coverage Report for Build 14640870200

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.1%) to 81.603%

Totals Coverage Status
Change from base Build 14640834283: 4.1%
Covered Lines: 671
Relevant Lines: 774

💛 - Coveralls

Copy link
Collaborator

@gagik gagik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, might need updates after #103

content: [
{
text: "No method provided. Expected one of the following: `aggregate`, `find`, or `count`",
type: "text",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does isError: true, not fit here? is it too destructive?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also you can simply throw new Error("No method ...") and handleError will kick in

@nirinchev nirinchev force-pushed the ni/integration-read branch from 09b74ec to b5b5edc Compare April 24, 2025 11:36
@nirinchev nirinchev force-pushed the ni/integration-update branch from 3bc4725 to 3d6113c Compare April 24, 2025 11:43
Base automatically changed from ni/integration-read to main April 24, 2025 11:47
@nirinchev nirinchev force-pushed the ni/integration-update branch from 3d6113c to 3ff3af0 Compare April 24, 2025 11:48
@nirinchev nirinchev merged commit 0584f38 into main Apr 24, 2025
8 checks passed
@nirinchev nirinchev deleted the ni/integration-update branch April 24, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants