-
Notifications
You must be signed in to change notification settings - Fork 228
feat(compass-crud): add document and field collection tab right click menus COMPASS-9387 #6988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gagik/context-menu-compass-ui
Are you sure you want to change the base?
Conversation
@@ -66,7 +66,7 @@ | |||
"mongodb-instance-model": "^12.31.0", | |||
"nyc": "^15.1.0", | |||
"react-dom": "^17.0.2", | |||
"sinon": "^8.1.1", | |||
"sinon": "^17.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this didn't end up being necessary but just leaving it as this aligns the version with other packages.
…/compass into gagik/collection-tab
…/compass into gagik/collection-tab
@@ -409,6 +411,16 @@ export const calculateShowMoreToggleOffset = ({ | |||
return spacerWidth + editableOffset + expandIconSize; | |||
}; | |||
|
|||
// Helper function to check if a string is a URL | |||
const isValidUrl = (str: string): boolean => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will likely want to move this to a helper
…/compass into gagik/collection-tab
In manual testing noticed that copying a field that is an array leads to a null value; will need to follow up. |
In List View:
In JSON View:
Adds right click functionality to the individual fields as well as the entire document in the document view.
Follow-ups:
See also: #6996