Added a call to save to a storage on item update() #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither
Cart::update($id, 'price', $price);
norCart::item($id)->update('price',$price);
triggers saving to a storage, therefore on next Cart construction the updates are lost.I initially wanted to add another method to a storage save() which would call saveCart() protected method since with the above approach the following won't trigger update:
But adding a
$this->store->insertUpdate($this)
within an Item object is better, since attribute value reassignment doesn't really tell us that the item has been updated and saved.Regards,
Alex