Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input didn't handle UTF-16 to UTF-8 conversion properly (why is this converted in the first place?) - it truncated the bytes. For the ASCII subset of Unicode, this works fine. For other Unicode characters (e.g. emoji), this is invalid. Since we're on Windows, we can use
WideCharToMultiByte
.Semi-related changes:
Console Example
--input
Qt Example
I tested this with the input
hello 😂😂😂😂
and verified that it prints correctly in the terminal (I used VS Code's terminal and MS terminal). This might not display correctly in CMD, so Microsoft's new Terminal has to be used. When testing the Qt version, set$Env:QT_WIN_DEBUG_CONSOLE="attach"
(powershell), so the app prints to the parent console.