Share flalback #3893
Open
Share flalback #3893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configuration - Add Cypress config files for next-app-router-4000 and next-app-router-4001 - Create test directory structure with support files and fixtures - Add basic e2e tests for both apps - Configure proper TypeScript settings for Cypress 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
# Conflicts: # apps/next-app-router/next-app-router-4000/cypress.config.ts # apps/next-app-router/next-app-router-4000/cypress/support/commands.ts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
ConsumeSharedPluginclass inpackages/enhanced/src/lib/sharing/ConsumeSharedPlugin.tsby improving fallback logic for resolving shared module dependencies. The changes ensure that the plugin attempts to match unresolved dependencies with and without theissuerLayercontext, increasing the robustness of dependency resolution.Enhancements to dependency resolution logic:
Updated the
matchvariable to attempt resolution both with and without theissuerLayercontext when looking up shared modules. This change ensures fallback behavior in case theissuerLayer-specific lookup fails.Improved the
moduleMatchlogic to include fallback resolution for module paths afternode_modules, trying both with and without theissuerLayercontext.Enhanced the
reconstructedMatchlogic to apply the same fallback mechanism for the full reconstructed path, increasing the likelihood of finding a match when theissuerLayeris undefined.