Skip to content

Build project and adapt package exports #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: cursor/create-rslib-executor-for-nx-3342
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

## Description

This PR adapts the `runtime-core` package to use Rslib's default file naming conventions for its build output.

Key changes include:
*   **Updated `package.json` exports**: `main`, `module`, `exports`, and `types` fields are now correctly configured to reference the default `.js`, `.cjs`, and `.d.ts` files generated by Rslib in the `dist` directory.
*   **Enabled Declaration File Generation**: Configured `runtime-core` to correctly generate and reference TypeScript declaration files (`.d.ts`).
*   **Resolved Build Errors**: Fixed a `TS1192` error in the `runtime` package by correcting an incorrect default import from `runtime-core`.

These changes ensure the `runtime-core` package builds successfully with standard Rslib output and has correctly configured package exports for consumers.

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here: -->


## Types of changes

- [ ] Docs change / refactoring / dependency upgrade
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)

## Checklist

- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [ ] I have updated the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants