update deduce_base to include error handingling #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AdityaKhowalGithub, @ZolotukhinM Is there anything I could do to get this over the line? |
|
there is a lint error, i can take a look later today |
|
@iwahbe not sure how to get workflow approval but would love a CR if u have time |
|
The code looks good to me, but I'm just a user of the project who wanted to see this improve. I'm not a maintainer. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves error handling in the
deduce_basefunction to prevent crashes when remote branches are missing or merge-base fails.Changes
Error Examples
Testing
Verified the tool exits gracefully with appropriate messages when remote branch is missing or merge-base fails.