Skip to content

[BigQueryReservation] Add 'reservation_group' field to google_bigquery_reservation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScottSuarez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BigQueryReservation] Add 'reservation_group' field to google_bigquery_reservation #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions mmv1/products/bigqueryreservation/Reservation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ examples:
exclude_docs: true
vars:
name: my-reservation
- name: bigquery_reservation_with_reservation_group
primary_resource_id: reservation
vars:
group_name: my-group
name: my-reservation
test_env_vars:
project: PROJECT_NAME
parameters:
- name: location
type: String
Expand Down Expand Up @@ -248,3 +255,6 @@ properties:
- autoscale
required_with:
- scalingMode
- name: reservationGroup
type: String
description: 'Optional. The reservation group that this reservation belongs to. You can set this property when you create or update a reservation. Reservations do not need to belong to a reservation group. Format: projects/{project}/locations/{location}/reservationGroups/{reservation_group} or just {reservation_group}'
14 changes: 14 additions & 0 deletions mmv1/templates/terraform/examples/bigquery_reservation_with_reservation_group.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
resource "google_bigquery_reservation" "{{$.PrimaryResourceId}}" {
name = "{{index $.Vars "name"}}"
location = "us-west2"
// Set to 0 for testing purposes
// In reality this would be larger than zero
slot_capacity = 0
edition = "STANDARD"
ignore_idle_slots = true
concurrency = 0
autoscale {
max_slots = 100
}
reservation_group = "projects/{{index $.TestEnvVars "project"}}/locations/us-west2/reservationGroups/{{index $.Vars "group_name"}}"
}
Loading