Skip to content

fix(mfusg): fix multiple bugs#2770

Merged
wpbonelli merged 3 commits into
modflowpy:developfrom
wpbonelli:fix-2763
Jun 10, 2026
Merged

fix(mfusg): fix multiple bugs#2770
wpbonelli merged 3 commits into
modflowpy:developfrom
wpbonelli:fix-2763

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Jun 9, 2026

Copy link
Copy Markdown
Member

Fix what look like copy/paste errors in mfusgrch.py, missing leading f in front of format strings in several places, and a bad format specifier

@wpbonelli wpbonelli added this to the 3.10.1 milestone Jun 9, 2026
@wpbonelli wpbonelli added the bug label Jun 9, 2026
@wpbonelli wpbonelli marked this pull request as ready for review June 9, 2026 19:31
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.5%. Comparing base (556c088) to head (c89439c).
⚠️ Report is 173 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/mfusg/mfusgoc.py 0.0% 5 Missing ⚠️
flopy/mfusg/mfusgrch.py 50.0% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2770      +/-   ##
===========================================
+ Coverage     55.5%    72.5%   +17.0%     
===========================================
  Files          644      677      +33     
  Lines       124135   132714    +8579     
===========================================
+ Hits         68947    96344   +27397     
+ Misses       55188    36370   -18818     
Files with missing lines Coverage Δ
flopy/mfusg/mfusgrch.py 77.9% <50.0%> (ø)
flopy/mfusg/mfusgoc.py 59.9% <0.0%> (ø)

... and 578 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwtoews mwtoews linked an issue Jun 9, 2026 that may be closed by this pull request

@mwtoews mwtoews left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the test should be moved to where it is more relevant.

Comment thread autotest/test_usg.py Outdated
@wpbonelli

Copy link
Copy Markdown
Member Author

thanks @mwtoews nice catch

@wpbonelli wpbonelli merged commit 60db7e7 into modflowpy:develop Jun 10, 2026
19 checks passed
@wpbonelli wpbonelli deleted the fix-2763 branch June 10, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: USG recharge seepage elevation

2 participants