- 
                Notifications
    
You must be signed in to change notification settings  - Fork 342
 
feat: Added simple function to mfdis.py #2056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
          Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@            Coverage Diff            @@
##           develop   #2056     +/-   ##
=========================================
- Coverage     73.0%   73.0%   -0.1%     
=========================================
  Files          259     259             
  Lines        59298   57932   -1366     
=========================================
- Hits         43305   42294   -1011     
+ Misses       15993   15638    -355     
  | 
    
| 
           You will need to relint with black (see failed test). Also to maintain code coverage you need to add a small test of your function that confirms that you get expected results for a known case.  | 
    
| 
           Sure, I reformatted with black. I will push again when I add the CI test.  | 
    
| stp = [] | ||
| perlen = [] | ||
| for iper in range(self.nper): | ||
| per.append(iper + 1) # Use 1-based indexing | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably best to return 0-based per flopy3+ convention
| 
           @camille12225   | 
    
New function returns 3 lists of integers for