Merge pull request #145 from moderntribe/feature/action-workflows-cle…

…anup Feature/action workflows cleanup
moderntribe · Jun 21, 2024 · c09f6cf · c09f6cf
2 parents ebf4990 + 81e38c2
commit c09f6cf
Show file tree

Hide file tree

Showing 12 changed files with 38 additions and 25 deletions.
diff --git a/.github/workflows/workflows.yml → .github/workflows/code-quality.yml b/.github/workflows/workflows.yml → .github/workflows/code-quality.yml
@@ -1,4 +1,4 @@
-name: 'Workflows'
+name: 'Code Quality Checks'
 
 on:
   workflow_dispatch:

diff --git a/.github/workflows/deploy-dev.yml b/.github/workflows/deploy-dev.yml
@@ -26,7 +26,7 @@ jobs:
 
       # Get Build Repository
       - name: Check out build branch
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           path: ${{ env.BUILD_FOLDER }}
           ref: ${{github.ref}}
@@ -52,7 +52,7 @@ jobs:
 
       # Set up node version
       - name: Set up node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version-file: "${{ env.BUILD_FOLDER }}/.nvmrc"
           cache: 'npm'

diff --git a/.github/workflows/deploy-prod.yml b/.github/workflows/deploy-prod.yml
@@ -28,7 +28,7 @@ jobs:
 
       # Get Build Repository
       - name: Check out build branch
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           path: ${{ env.BUILD_FOLDER }}
           ref: ${{github.ref}}
@@ -54,7 +54,7 @@ jobs:
 
       # Set up node version
       - name: Set up node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version-file: "${{ env.BUILD_FOLDER }}/.nvmrc"
           cache: 'npm'

diff --git a/.github/workflows/deploy-stage.yml b/.github/workflows/deploy-stage.yml
@@ -29,7 +29,7 @@ jobs:
 
       # Get Build Repository
       - name: Check out build branch
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           path: ${{ env.BUILD_FOLDER }}
           ref: ${{github.ref}}
@@ -55,7 +55,7 @@ jobs:
 
       # Set up node version
       - name: Set up node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version-file: "${{ env.BUILD_FOLDER }}/.nvmrc"
           cache: 'npm'

diff --git a/.github/workflows/dokku-review-app.yml b/.github/workflows/dokku-review-app.yml
@@ -1,4 +1,4 @@
-name: Dokku Deploy Review App
+name: 'Dokku Review App'
 
 on:
   workflow_dispatch:
@@ -45,3 +45,11 @@ jobs:
     secrets:
       github_pat_token: ${{ secrets.GH_BOT_TOKEN }}
       server: d1.moderntribe.qa
+
+  complete_workflow:
+    if: ${{ always() }}
+    needs: [create_review_app, deploy_review_app, destroy_review_app]
+    runs-on: ubuntu-latest
+    steps:
+      - name: Complete Workflow
+        run: echo "Dokku Deploy Review App workflow complete."
diff --git a/.github/workflows/lighthouse-ci.yml b/.github/workflows/lighthouse-ci.yml
@@ -5,9 +5,9 @@ jobs:
   lighthouse:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Audit URLs using Lighthouse
-        uses: treosh/lighthouse-ci-action@v10
+        uses: treosh/lighthouse-ci-action@v11
         with:
           urls: |
             https://moose-dev.d1.moderntribe.qa/?secret=1

diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
@@ -9,10 +9,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Detect File Changes
-        uses: dorny/paths-filter@v2
+        uses: dorny/paths-filter@v3
         id: changed-files
         with:
           list-files: shell
@@ -25,7 +25,7 @@ jobs:
 
       - name: Set up node
         if: steps.changed-files.outputs.linting == 'true'
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version-file: './.nvmrc'
           cache: 'npm'

diff --git a/.github/workflows/php-tests.yml b/.github/workflows/php-tests.yml
@@ -24,12 +24,12 @@ jobs:
 
     steps:
       - name: Checkout the repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           path: ${{ env.build_folder }}
 
       - name: Detect File Changes
-        uses: dorny/paths-filter@v2
+        uses: dorny/paths-filter@v3
         id: changed-files
         with:
           working-directory: ${{ env.build_folder }}
@@ -42,7 +42,7 @@ jobs:
 
       - name: Checkout slic
         if: steps.changed-files.outputs.tests == 'true'
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: stellarwp/slic
           ref: main

diff --git a/.github/workflows/phpcs.yml b/.github/workflows/phpcs.yml
@@ -13,10 +13,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Detect File Changes
-        uses: dorny/paths-filter@v2
+        uses: dorny/paths-filter@v3
         id: changed-files
         with:
           list-files: shell
@@ -32,7 +32,7 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           tools: composer:2
-          php-version: '8.0'
+          php-version: '8.1'
 
       - name: Get Composer Cache Directory
         id: composer-cache

diff --git a/.github/workflows/pipeline-dokku.yml b/.github/workflows/pipeline-dokku.yml
@@ -38,7 +38,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Cloning repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           ref: ${{ inputs.branch }}
@@ -61,7 +61,7 @@ jobs:
           mv .deploy/config/local-config-dokku.php local-config.php
 
       - name: Setup node version
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version-file: './.nvmrc'
           cache: 'npm'

diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml
@@ -13,12 +13,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
       - name: Detect File Changes
-        uses: dorny/paths-filter@v2
+        uses: dorny/paths-filter@v3
         id: changed-files
         with:
           list-files: shell
@@ -33,7 +33,7 @@ jobs:
         if: steps.changed-files.outputs.phpstan == 'true'
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '8.0'
+          php-version: '8.1'
           extensions: mbstring, intl
           coverage: none
           tools: composer:2
@@ -44,7 +44,7 @@ jobs:
         run: |
           echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
 
-      - uses: actions/cache@v3
+      - uses: actions/cache@v4
         if: steps.changed-files.outputs.phpstan == 'true'
         with:
           path: ${{ steps.composer-cache.outputs.dir }}

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). Each changelog entry gets prefixed with the category of the item (Added, Changed, Depreciated, Removed, Fixed, Security).
 
+## [2024.06]
+- Changed: Renamed and added a finish job to the Dokku Deploy App workflow so that it doesn't fail when all 3 app jobs are skipped.
+- Changed: Renamed the code quality workflow from "Workflow" to "Code Quality Checks" and renamed the file accordingly.
+- Updated: Updated GitHub default & 3rd-party action versions to eliminate (node version warnings)[https://github.com/moderntribe/moose/actions/runs/9617664104].  
+
 ## [2024.05]
 - Updated: Pattern definition consistency for usage of `Inserter:`
 - Updated: Post pattern now shows up in the pattern selector when adding a new post.