Merge pull request #180 from moderntribe/feature/MOOSE-172/admin-menu…

…-cleanup

[MOOSE-172] Admin Menu Cleanup

CHANGELOG.md

@@ -6,11 +6,13 @@ item (Added, Changed, Depreciated, Removed, Fixed, Security).
 
 ## [2025.01]
 
+- Added: `Admin_Menu_Order` class to handle reordering the WP Admin menu items that Moose loads with by default.
+  This also includes Yoast SEO & RankMath, just in case either are used by default. 
 - Added: Node service to Lando so FE assets can be built automatically on start up.
 - Updated: project start up scripts to automatically generate the correct contents of the lcoal config files.
 - Updated: script to install WordPress so we can use a version constant and not install WP every time composer is
   installed or updated.
-- Updated: ESLint config now supports browser environment variable such as `IntersectionObserver`
+- Updated: ESLint config now supports browser environment variables such as `IntersectionObserver`
 - Added: ability for table blocks to utilize the `overflow-x` set on them by setting a `min-width` property for the
   `table` element within the table block.
 - Updated: Enabled background images on the Group block; We should try to use this instead of the Cover block where

wp-content/plugins/core/src/Core.php

@@ -23,11 +23,12 @@ class Core {
 	 * @var string[] Names of classes extending Abstract_Subscriber.
 	 */
 	private array $subscribers = [
-		Settings\Settings_Subscriber::class,
 		Assets\Assets_Subscriber::class,
 		Blocks\Blocks_Subscriber::class,
 		Integrations\Integrations_Subscriber::class,
+		Menus\Menu_Subscriber::class,
 		Object_Meta\Meta_Subscriber::class,
+		Settings\Settings_Subscriber::class,
 		Theme_Config\Theme_Config_Subscriber::class,
 
 		// Post Types

wp-content/plugins/core/src/Menus/Admin_Menu_Order.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types=1);
+
+namespace Tribe\Plugin\Menus;
+
+class Admin_Menu_Order {
+
+	public function custom_menu_order(): array {
+		return [
+			'index.php',
+			'separator1',
+			'edit.php?post_type=page',
+			// place CPTs here
+			'edit.php',
+			'upload.php',
+			'gf_edit_forms',
+			'separator2',
+			'themes.php',
+			'plugins.php',
+			'users.php',
+			'tools.php',
+			'options-general.php',
+			'edit.php?post_type=training',
+			'separator-last',
+			'edit.php?post_type=acf-field-group',
+			'wpseo_dashboard',
+			'rank-math',
+		];
+	}
+
+}

wp-content/plugins/core/src/Menus/Menu_Subscriber.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types=1);
+
+namespace Tribe\Plugin\Menus;
+
+use Tribe\Plugin\Core\Abstract_Subscriber;
+
+class Menu_Subscriber extends Abstract_Subscriber {
+
+	public function register(): void {
+		add_filter( 'custom_menu_order', '__return_true' );
+
+		add_filter( 'menu_order', function (): array {
+			return $this->container->get( Admin_Menu_Order::class )->custom_menu_order();
+		} );
+	}
+
+}

wp-content/plugins/core/src/Post_Types/Training/Config.php

@@ -29,9 +29,10 @@ public function get_args(): array {
 
 	public function get_labels(): array {
 		return [
-			'singular' => __( 'Training Doc', 'tribe' ),
-			'plural'   => __( 'Training Docs', 'tribe' ),
-			'slug'     => $this->post_type,
+			'singular'  => __( 'Training Doc', 'tribe' ),
+			'plural'    => __( 'Training Docs', 'tribe' ),
+			'menu_name' => __( 'Training', 'tribe' ),
+			'slug'      => $this->post_type,
 		];
 	}