-
Notifications
You must be signed in to change notification settings - Fork 23
test(git): Enhance Git parser tests with temporary repository setup #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @aftersnow, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the reliability and maintainability of the Git parser tests. By transitioning from a static test fixture to a dynamically generated Git repository, the tests now more accurately simulate real-world Git environments, ensuring that the parser correctly extracts information from various repository states. This change reduces the potential for test flakiness and improves the overall quality of the testing suite. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the Git parser test by replacing a static test data directory with a dynamically created temporary Git repository. This change makes the test suite more robust and self-contained. The implementation is clean and follows good practices for testing in Go. I have one suggestion to further improve the test's determinism.
Added a temporary Git repository setup in the test for the Git parser. This includes initializing a repository, creating a remote, adding a test file, and committing it before parsing. Updated assertions to verify the correct URL and commit SHA from the newly created repository. Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
e6c3ce0 to
06896b9
Compare
| // Now test the git parser | ||
| parser := &git{} | ||
| info, err := parser.Parse("testdata/git-repo") | ||
| info, err := parser.Parse(tempDir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we used temp for testing, so we can remove the original testdata/git-repo directory?
Added a temporary Git repository setup in the test for the Git parser. This includes initializing a repository, creating a remote, adding a test file, and committing it before parsing. Updated assertions to verify the correct URL and commit SHA from the newly created repository.