-
Notifications
You must be signed in to change notification settings - Fork 172
Fix spelling #4505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix spelling #4505
Conversation
5302cad
to
c9c5254
Compare
c9c5254
to
da6fac7
Compare
da6fac7
to
46f5fa3
Compare
46f5fa3
to
28136bb
Compare
WalkthroughThe changes consist of a spelling correction in an assertion message within the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/checkCron.yml (1)
81-81
: Skip Utilities.mo in the bulk spelling run
Including./ModelicaTest/Utilities.mo
in the final--skip
list prevents duplicate errors after your targeted check. Functionally this is sound. Consider an optional cleanup: move the long comma‑separated skip list into a dedicated file (e.g..codespellskip
) and reference it via--skip-file
to improve maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/checkCron.yml
(1 hunks)ModelicaTest/Utilities.mo
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: external_c_checks_cmake_windows-msvc
- GitHub Check: external_c_checks_cmake_windows-cygwin
🔇 Additional comments (2)
.github/workflows/checkCron.yml (1)
79-79
: Enable spelling check for Utilities.mo
The newcodespell -L fo ./ModelicaTest/Utilities.mo
invocation correctly brings your updated test file into the spelling pipeline so the “occurrences” fix is verified.ModelicaTest/Utilities.mo (1)
220-220
:✅ Verification successful
Correct spelling in assertion message
The change from “occurences” to “occurrences” in theStrings.contains 2 failed (multiple occurrences)
message is accurate and aligns with English spelling. Please verify that no other instances of the old typo remain across the repo:
🏁 Script executed:
#!/bin/bash # Search for any leftover "occurences" typos rg -n "occurences" .Length of output: 20
All instances of “occurences” have been removed
I ranrg -n "occurences" .
across the repository and found no remaining typos. The spelling correction inModelicaTest/Utilities.mo
is complete.
Follow-up of #4493.
As reported by https://github.com/modelica/ModelicaStandardLibrary/actions/runs/11875525138/job/33092839921
Summary by CodeRabbit
Bug Fixes
Chores