Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer protection #3629

Merged
merged 8 commits into from
Apr 10, 2025
Merged

Clearer protection #3629

merged 8 commits into from
Apr 10, 2025

Conversation

HansOlsson
Copy link
Collaborator

Closes #3622

In particular:

  • Be consistent with examples, I don't know why we have claimed that "Authorization" was in Protection.
  • Be more explicit with nested records.

henrikt-ma
henrikt-ma reviewed Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleanup looks good to me, but since System Modeler does not implement this annotation, I am not in a good position to provide a review with approval.

HansOlsson
HansOlsson commented Jan 8, 2025
View reviewed changes
@HansOlsson HansOlsson added this to the 2025-January milestone Jan 8, 2025
@HansOlsson HansOlsson requested a review from adrpo January 9, 2025 15:13
@HansOlsson
Copy link
Collaborator Author

@casella to check with @adrpo

@HansOlsson
Copy link
Collaborator Author

@casella to check with @adrpo

Ping @casella @adrpo

@HansOlsson HansOlsson modified the milestones: 2025-January, 2025-March Mar 5, 2025
@HansOlsson
Copy link
Collaborator Author

@gkurzbach to check with colleague

@HansOlsson
Copy link
Collaborator Author

@MarkusOlssonModelon to check as well

MarkusOlssonModelon
MarkusOlssonModelon reviewed Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@MarkusOlssonModelon MarkusOlssonModelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to Protection and UserLicense look good to me. We don't use the Authorization annotation however, so it would be good if someone else reviewed that.

@HansOlsson HansOlsson mentioned this pull request Apr 10, 2025
Open
gkurzbach
gkurzbach approved these changes Apr 10, 2025
View reviewed changes
@HansOlsson HansOlsson merged commit c7074f4 into modelica:master Apr 10, 2025
1 check passed
@HansOlsson HansOlsson deleted the ClearerProtection branch April 10, 2025 14:14
@beutlich beutlich removed the request for review from adrpo April 11, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikt-ma henrikt-ma henrikt-ma left review comments

@MarkusOlssonModelon MarkusOlssonModelon MarkusOlssonModelon left review comments

@gkurzbach gkurzbach gkurzbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2025-March
Development

Successfully merging this pull request may close these issues.

How to use the Protection annotation(s)
4 participants
@HansOlsson @henrikt-ma @gkurzbach @MarkusOlssonModelon