fix: continue auth discovery after invalid JSON#2217
Open
he-yufeng wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 9f7b870 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the OAuth authorization-server metadata endpoint responds with
200 OKbut the body is not JSON, discovery currently stops on the JSON parse error. That prevents the client from trying the next well-known URL, including the OIDC metadata fallback.This treats an unreadable discovery body the same way as an unavailable discovery endpoint and continues to the next candidate URL. Schema validation errors still surface once a JSON document is actually parsed.
Fixes #2126.
Tested
pnpm --filter @modelcontextprotocol/client test -- test/client/auth.test.tspnpm --filter @modelcontextprotocol/client typecheckpnpm --filter @modelcontextprotocol/client lintpnpm --filter @modelcontextprotocol/client buildgit diff --checkThe repository pre-push hook also ran
pnpm -r build,pnpm -r typecheck, andpnpm lint:allsuccessfully.