feat(server): add host process watchdog to StdioServerTransport#1572
Closed
aptsalt wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
feat(server): add host process watchdog to StdioServerTransport#1572aptsalt wants to merge 1 commit intomodelcontextprotocol:mainfrom
aptsalt wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
When clientProcessId is provided, the transport periodically checks if the host process is alive using signal 0 and self-terminates if the host is gone. This prevents orphaned server processes when the host crashes without cleanly shutting down. Closes #208 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 25c2a3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clientProcessIdoption toStdioServerTransportthat enables a watchdog timerprocess.kill(pid, 0))watchdogIntervalMs(default: 3s)StdioServerTransportOptionsinterface with backwards-compatible constructor overloadsunref()so it doesn't prevent clean process exitFollows the same pattern used in vscode-languageserver-node as suggested in the issue.
Closes #208
Test plan
should close transport when host process is gone— watchdog detects dead PID and closesshould not close when host process is alive— no false positives with own PIDshould stop watchdog on close— cleanup on transport closeshould accept options object constructor— new constructor form works🤖 Generated with Claude Code