fix(client): wait for in-flight requests before aborting on close()#1569
Closed
aptsalt wants to merge 2 commits intomodelcontextprotocol:mainfrom
Closed
fix(client): wait for in-flight requests before aborting on close()#1569aptsalt wants to merge 2 commits intomodelcontextprotocol:mainfrom
aptsalt wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
Both SSEClientTransport and StreamableHTTPClientTransport now track pending send() requests and wait for them to settle (with a 2s timeout) before calling AbortController.abort(). This prevents Undici and OpenTelemetry instrumentation from marking successful 200 OK responses as UND_ERR_ABORTED when close() is called while requests are in-flight. Closes #1231
🦋 Changeset detectedLatest commit: d215fff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send()requests in bothSSEClientTransportandStreamableHTTPClientTransportclose()now waits for pending requests to settle (with a 2s timeout) before callingAbortController.abort()UND_ERR_ABORTEDContext
Fixes #1231 — When
close()is called while POST requests are still in-flight, the immediateAbortController.abort()causes Undici to reportUND_ERR_ABORTEDeven though the server returned 200 OK. This creates misleading telemetry in OpenTelemetry traces.Changes
packages/client/src/client/streamableHttp.ts_pendingRequestsSet to track activesend()callssend()registers/unregisters itself from the set usingtry/finallyclose()waits up to 2s for pending requests before abortingpackages/client/src/client/sse.tspackages/client/test/client/streamableHttp.test.tsTest plan
pnpm build:all)Closes #1231