fix: register logging/setLevel handler via registerCapabilities#1508
Open
corvid-agent wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: register logging/setLevel handler via registerCapabilities#1508corvid-agent wants to merge 2 commits intomodelcontextprotocol:mainfrom
corvid-agent wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
…ed via registerCapabilities When logging capability was added via `registerCapabilities()` instead of the constructor options, the `logging/setLevel` request handler was not being registered, causing setLevel requests to fail silently. Extract the handler registration into a private `registerLoggingHandler()` method with an idempotency guard, and call it from both the constructor and `registerCapabilities()`. Fixes modelcontextprotocol#1464 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: d25511f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerCapabilitiesto properly register thelogging/setLevelrequest handler when the logging capability is added after constructionregisterLoggingHandler()method with an idempotency guard, called from both the constructor andregisterCapabilities()setLoggingLevelworks when logging is registered viaregisterCapabilities()Fixes #1464
Test plan
client.setLoggingLevel()works when server usesregisterCapabilities({ logging: {} })instead of constructor optionsregisterCapabilities()🤖 Generated with Claude Code