Fix create_directory for nested paths with non-existent parents - #4679
Open
sachinsharma3191 wants to merge 1 commit into
Open
Fix create_directory for nested paths with non-existent parents#4679sachinsharma3191 wants to merge 1 commit into
sachinsharma3191 wants to merge 1 commit into
Conversation
…tories validatePath() now accepts an `allowNonExistentAncestors` option that walks up using path.dirname() until it finds an existing ancestor directory, then validates that ancestor against the allowed directories list. This enables recursive mkdir (mkdir -p) to work when multiple levels of parent directories don't exist yet, matching the documented behavior of create_directory. Fixes modelcontextprotocol#4629
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4629
ValidatePathOptionsinterface withallowNonExistentAncestorsflag tovalidatePath()path.dirname()to find the first existing ancestor and validates it against allowed directoriescreate_directoryhandler now passes{ allowNonExistentAncestors: true }somkdir -pstyle recursive creation works correctlyTest plan
create_directorywith nested non-existent parents succeeds when ancestor is in allowed dirscreate_directorystill rejects paths outside allowed directoriesvalidatePath()behavior (without flag) unchanged — existing tests pass