chore: remove the rig example#763
Open
jokemanfire wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
chore: remove the rig example#763jokemanfire wants to merge 1 commit intomodelcontextprotocol:mainfrom
jokemanfire wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
The rig official has the mcp example, we need not to keep it just give the link. Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the in-repo rig-integration example to reduce maintenance burden, and replaces its listing in the examples index with a link to the upstream Rig MCP example.
Changes:
- Deleted the
examples/rig-integrationexample crate (source, config, and manifest). - Updated
examples/README.mdto point the Rig integration example to the upstream Rig repository.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/rig-integration/src/mcp_adaptor.rs | Removed Rig↔MCP adaptor implementation as part of deleting the example. |
| examples/rig-integration/src/main.rs | Removed the example CLI entrypoint. |
| examples/rig-integration/src/config/mcp.rs | Removed MCP transport/server config for the example. |
| examples/rig-integration/src/config.rs | Removed example configuration loader/types. |
| examples/rig-integration/src/chat.rs | Removed streaming CLI chat UI for the example. |
| examples/rig-integration/config.toml | Removed example runtime configuration. |
| examples/rig-integration/Cargo.toml | Removed the example crate manifest from the workspace glob. |
| examples/README.md | Replaced local Rig example link with an external upstream link. |
DaleSeo
approved these changes
Mar 21, 2026
Member
DaleSeo
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up, @jokemanfire!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rig official has the mcp example, we need not to keep it just give the link.
Motivation and Context
Reduce example maintenance work
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context