Skip to content

feat: add progress notification handling and related structures #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2025
Merged

feat: add progress notification handling and related structures #282

merged 2 commits into from
Jun 25, 2025

Conversation

4t145
Copy link
Collaborator

@4t145 4t145 commented Jun 24, 2025

also fix some bugs

Feature

Add a progress notification dispatcher, so user can get the progress in a stream

Bug fix

  1. fix lifetime error when async tool function has no callee
  2. fix lose meta data

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@4t145
feat: add progress notification handling and related structures
88fc0d8 
also fix some lifetime bugs of tool macro
@4t145 4t145 requested a review from jokemanfire June 24, 2025 11:45
@github-actions github-actions bot added T-dependencies Dependencies related changes T-test Testing related changes T-config Configuration file changes T-core Core library changes T-handler Handler implementation changes T-macros Macro changes T-model Model/data structure changes labels Jun 24, 2025
@jokemanfire
Copy link
Collaborator

thanks , If it related to #271 ?

jokemanfire
jokemanfire previously approved these changes Jun 25, 2025
View reviewed changes
@4t145
Copy link
Collaborator Author

4t145 commented Jun 25, 2025

@jokemanfire yes, just trying to make it a little easier to use.

@4t145 4t145 requested a review from jokemanfire June 25, 2025 02:56
@4t145 4t145 merged commit 8e1490b into modelcontextprotocol:main Jun 25, 2025
20 of 21 checks passed
@github-actions github-actions bot mentioned this pull request Jul 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokemanfire jokemanfire jokemanfire approved these changes

Assignees
No one assigned
Labels
T-config Configuration file changes T-core Core library changes T-dependencies Dependencies related changes T-handler Handler implementation changes T-macros Macro changes T-model Model/data structure changes T-test Testing related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4t145 @jokemanfire