Repository navigation
Conversation
## Motivation and Context `MCP::ServerContext` is the class a handler receives as `server_context:`, and the docs name it as such, but `lib/mcp.rb` never listed it: its file was required by `lib/mcp/server.rb` alone, so an application referring to the class before anything had loaded `MCP::Server`, in a type check or a test double, got `NameError: uninitialized constant MCP::ServerContext`. Every other class the docs name resolves from the entry point; this adds the missing entry. Closes modelcontextprotocol#655 ## How Has This Been Tested? test/mcp/server_context_test.rb: a fresh process that requires `mcp` and resolves `MCP::ServerContext` without touching `MCP::Server`; before the change it ends with the `NameError` above. ## Breaking Changes None.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
MCP::ServerContextis the class a handler receives asserver_context:, and the docs name it as such, butlib/mcp.rbnever listed it: its file was required bylib/mcp/server.rbalone, so an application referring to the class before anything had loadedMCP::Server, in a type check or a test double, gotNameError: uninitialized constant MCP::ServerContext. Every other class the docs name resolves from the entry point; this adds the missing entry.Closes #655
How Has This Been Tested?
test/mcp/server_context_test.rb: a fresh process that requires
mcpand resolvesMCP::ServerContextwithout touchingMCP::Server; before the change it ends with theNameErrorabove.Breaking Changes
None.
Types of changes
Checklist