Skip to content

tests: use inline_snapshot.Is on parametrized test #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+25 −24
Open

tests: use inline_snapshot.Is on parametrized test #945

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7106f4
tests: use `inline_snapshot.Is` on parametrized test
Kludex Jun 12, 2025
a844eec
Drop Is
Kludex Jun 12, 2025
598bd8a
update again
Kludex Jun 12, 2025
ec980dd
Add comment and ignore test
Kludex Jun 13, 2025
0d8595c
Merge branch 'main' into fix-test-with-snapshot
Kludex Jun 13, 2025
91722aa
Merge branch 'main' into fix-test-with-snapshot
Kludex Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions tests/client/test_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

import httpx
import pytest
from inline_snapshot import snapshot
from inline_snapshot import Is, snapshot
from pydantic import AnyHttpUrl, AnyUrl

from mcp.client.auth import OAuthClientProvider
Expand Down Expand Up @@ -836,15 +836,16 @@ async def test_token_exchange_error_basic(self, oauth_provider, oauth_client_inf
"revocation_endpoint",
),
(
pytest.param(
"https://auth.example.com",
"https://auth.example.com/docs",
"https://auth.example.com/authorize",
"https://auth.example.com/token",
"https://auth.example.com/register",
"https://auth.example.com/revoke",
id="simple-url",
),
# TODO(Marcelo): Since we are using `AnyUrl`, the trailing slash is always added.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be just removed? or add a note when this test should be added back

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be turned into a xfail - to show that it's the wrong behavior.

# pytest.param(
# "https://auth.example.com",
# "https://auth.example.com/docs",
# "https://auth.example.com/authorize",
# "https://auth.example.com/token",
# "https://auth.example.com/register",
# "https://auth.example.com/revoke",
# id="simple-url",
# ),
pytest.param(
"https://auth.example.com/",
"https://auth.example.com/docs",
Expand Down Expand Up @@ -880,18 +881,18 @@ def test_build_metadata(
revocation_options=RevocationOptions(enabled=True),
)

assert metadata == snapshot(
OAuthMetadata(
issuer=AnyHttpUrl(issuer_url),
authorization_endpoint=AnyHttpUrl(authorization_endpoint),
token_endpoint=AnyHttpUrl(token_endpoint),
registration_endpoint=AnyHttpUrl(registration_endpoint),
scopes_supported=["read", "write", "admin"],
grant_types_supported=["authorization_code", "refresh_token"],
token_endpoint_auth_methods_supported=["client_secret_post"],
service_documentation=AnyHttpUrl(service_documentation_url),
revocation_endpoint=AnyHttpUrl(revocation_endpoint),
revocation_endpoint_auth_methods_supported=["client_secret_post"],
code_challenge_methods_supported=["S256"],
)
assert metadata.model_dump(exclude_defaults=True, mode="json") == snapshot(
{
"issuer": Is(issuer_url),
"authorization_endpoint": Is(authorization_endpoint),
"token_endpoint": Is(token_endpoint),
"registration_endpoint": Is(registration_endpoint),
"scopes_supported": ["read", "write", "admin"],
"grant_types_supported": ["authorization_code", "refresh_token"],
"token_endpoint_auth_methods_supported": ["client_secret_post"],
"service_documentation": Is(service_documentation_url),
"revocation_endpoint": Is(revocation_endpoint),
"revocation_endpoint_auth_methods_supported": ["client_secret_post"],
"code_challenge_methods_supported": ["S256"],
}
)
Loading