ci: remove continue-on-error from test job
#1964
Closed
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot PRs fail the claude-review check because the action rejects non-human actors that aren't in the allowed_bots list. Since Dependabot PRs are automated dependency bumps, they don't need a Claude code review. Skip the job entirely when the actor is dependabot[bot].
Make CI test failures blocking so that broken builds are not silently ignored. Previously the test matrix had `continue-on-error: true`, which allowed failing tests to pass the overall workflow. Co-Authored-By: Claude (fennec-v7-fast) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error: truefrom the test job inshared.ymlso that CI test failures are blockingTest plan
shared.ymlworkflow runs withoutcontinue-on-errorChangelog
🤖 Generated with Claude Code