fix: Add JsonInclude annotation to notification records for proper serialization #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rialization Add @JsonInclude(JsonInclude.Include.NON_ABSENT) to ResourcesUpdatedNotification and to LoggingMessageNotification This ensures that absent (null/Optional.empty()) fields are excluded from JSON serialization, preventing potential serialization issues with these MCP notification types. Signed-off-by: Christian Tzolov <[email protected]>
tzolov
added a commit
that referenced
this pull request
Sep 14, 2025
…rialization (#552) Add @JsonInclude(JsonInclude.Include.NON_ABSENT) to ResourcesUpdatedNotification and to LoggingMessageNotification This ensures that absent (null/Optional.empty()) fields are excluded from JSON serialization, preventing potential serialization issues with these MCP notification types. Signed-off-by: Christian Tzolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add JsonInclude annotations to notification records to ensure proper JSON serialization by excluding absent (null/Optional.empty()) fields from the serialized output.
Motivation and Context
The
ResourcesUpdatedNotificationandLoggingMessageNotificationrecords were missing the@JsonInclude(JsonInclude.Include.NON_ABSENT)annotation, which could lead to unnecessary null/absent fields being included in the JSON output. This change ensures consistent serialization behavior across all notification types and prevents potential issues with clients that may not handle absent fields correctly.How Has This Been Tested?
Breaking Changes
No breaking changes. This change only affects the JSON serialization output by excluding absent fields, which should not impact existing functionality. Clients will receive cleaner JSON without unnecessary null fields.
Types of changes
Checklist
Additional context
This change aligns the notification records with the existing pattern used throughout the codebase where
@JsonInclude(JsonInclude.Include.NON_ABSENT)is applied to ensure clean JSON serialization. The annotation specifically handles both null values and Optional.empty() cases, preventing them from appearing in the serialized JSON output.