fix(server): keep stdio SSE proxy alive after disconnect#1701
Open
AkhilTrivediX wants to merge 1 commit into
Open
fix(server): keep stdio SSE proxy alive after disconnect#1701AkhilTrivediX wants to merge 1 commit into
AkhilTrivediX wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
When an Inspector SSE client disconnected, a later stderr notification from the proxied stdio server could call
SSEServerTransport.send()after the transport had closed. Its rejected promise was unhandled, so Node exited withError: Not connected.The proxy now records the failed notification delivery while keeping the transport lifecycle running. The disconnected client still receives no message, but the Inspector process remains available for subsequent connections.
Closes #1014.
Testing
npm run test-servercd client && npm test -- --runInBandnpm run buildnpx prettier --check package.json server/package.json server/src/index.ts server/test/stdio-sse-close.test.ts