Skip to content

resolver(auth): avoid serializing unrelated auth callbacks#6645

Closed
crazy-max wants to merge 1 commit intomoby:masterfrom
crazy-max:resolver-auth-no-ser
Closed

resolver(auth): avoid serializing unrelated auth callbacks#6645
crazy-max wants to merge 1 commit intomoby:masterfrom
crazy-max:resolver-auth-no-ser

Conversation

@crazy-max
Copy link
Copy Markdown
Member

Follow-up to the narrow cancellation fix in #6641. That first fix only addressed the manual cancellation case and that more fixes were likely needed for the broader discussion.

That broader discussion is in #6633, where the report and follow-up comments point at unrelated auth and resolver work being stalled behind one slow or stuck auth path. This change hopefully addresses that remaining resolver-side serialization problem without taking the larger refactors proposed in the original patch stack.

This change narrows the resolver auth handler locking so one slow auth callback does not block unrelated auth work for the same resolver namespace.

The fetchers map synchronization now lives inside authHandlerNS helper methods instead of wrapping the whole Authorize and AddResponses flows. The resolver still snapshots and reuses cached auth fetchers the same way, but session callbacks such as Credentials, VerifyTokenAuthority, and token fetch work no longer run while muHandlers is held. I also added resolver tests that block one host in the real session auth RPC path and verify that an unrelated host can still complete its own AddResponses or Authorize flow.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the resolver-auth-no-ser branch from f9a6118 to 7242791 Compare April 2, 2026 13:04
@crazy-max crazy-max requested a review from tonistiigi April 2, 2026 13:37
@crazy-max crazy-max marked this pull request as ready for review April 2, 2026 13:37
@tonistiigi
Copy link
Copy Markdown
Member

ptal #6649

@crazy-max
Copy link
Copy Markdown
Member Author

ptal #6649

Yeah if the root issue is the wedged session tunnel path, then your changes make more sense.

@crazy-max crazy-max closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants