Handle instances where runc cannot be killed because it is not running [3/3]#6632
Open
glightfoot wants to merge 2 commits intomoby:masterfrom
Open
Handle instances where runc cannot be killed because it is not running [3/3]#6632glightfoot wants to merge 2 commits intomoby:masterfrom
glightfoot wants to merge 2 commits intomoby:masterfrom
Conversation
Signed-off-by: Greg Lightfoot <greg.lightfoot@reddit.com>
This was referenced Mar 30, 2026
Signed-off-by: Greg Lightfoot <greg.lightfoot@reddit.com>
4 tasks
tonistiigi
reviewed
Apr 20, 2026
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
Can you put together a reproduction case of integration test instead. The fix does n't look correct as you shouldn't return out from a failure to send a signal. The question would be why doesn't any current end mechanisms like context ending or p.ended trigger if container is dead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This final PR handles instances where runc has died and cannot be killed. Unfortunately, this is just string matching, but I couldn't find a better way to do it since we're dealing with shell ooutput.
Related PR's:
#6630
#6631
Fixes: #4483