[v0.12] test: remove testSchema1Image#6547
Conversation
Shubhranshu153
force-pushed
the
fix-v0.12-for-moby-25
branch
from
01faaba to
fbb996e
Compare
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
Just remove the test. We already dropped support for this in server side with containerdv2 https://github.com/moby/buildkit/blob/master/util/imageutil/config.go#L118
Shubhranshu153
force-pushed
the
fix-v0.12-for-moby-25
branch
from
fbb996e to
d17ea67
Compare
- Deprecate testSchema1Image: gcr.io no longer supports Schema1 manifests This changes ensure buildkit v0.12 tests pass with Moby v25. Signed-off-by: Shubhranshu Mahapatra <shubhum@amazon.com>
Shubhranshu153
force-pushed
the
fix-v0.12-for-moby-25
branch
from
d17ea67 to
91b4523
Compare
|
@tonistiigi Can i get review for this. Fixed the changes. |
| testWhiteoutParentDir, | ||
| testFrontendImageNaming, | ||
| testDuplicateWhiteouts, | ||
| testSchema1Image, |
There was a problem hiding this comment.
This line needs to be removed as well
crazy-max
changed the title
|
Is this PR still relevant? It seems to me like it was fairly time sensitive considering it was intended as a fix to some, what are now, fairly old versions. |
|
I'm going to close this because the version it addresses is quite old. If this is something that's still relevant and necessary, please give us more details. Otherwise, this seems like it might be more appropriate as a fork. |
|
@jsternberg this is still relevant because moby/moby's 25.0 branch is still actively maintained and imports buildkit v0.12. cc @thaJeztah @tonistiigi |
thaJeztah
changed the title
|
Looks like CI is failing because it's using older versions of some actions, so we'll probably need a backport of those first; 
|
|
Oh! There's a PR for that; #6663 |
6 participants
These changes ensure buildkit v0.12 tests pass with Moby v25.
Related PR: moby/moby#52027