fix: handle boolean exclusiveMaximum / exclusiveMinimum #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnahkies
added a commit
that referenced
this pull request
Nov 30, 2025
adds a couple of missing unit tests, split from #386
mnahkies
added a commit
that referenced
this pull request
Nov 30, 2025
no behavior changes yet, split from #386
mnahkies
force-pushed
the
mn/test/boost-unit-test-coverage
branch
from
7e3a1cb to
3dafb23
Compare
mnahkies
added a commit
that referenced
this pull request
Nov 30, 2025
adds direct unit tests for input schema normalization, covering most branches. this will facilitate several improvements / bug fixes in subsequent changes, split from #386
mnahkies
force-pushed
the
mn/test/boost-unit-test-coverage
branch
from
3dafb23 to
46b988f
Compare
mnahkies
changed the base branch from
main
to
mn/fix/always-extract-request-bodies
mnahkies
added a commit
that referenced
this pull request
Nov 30, 2025
as written, these tests are using `Schema` types not normalized `IRModel` types for the input. this needs correcting before `Schema` and `IRModel` begin to diverge, split from #386
mnahkies
force-pushed
the
mn/fix/always-extract-request-bodies
branch
from
bb5ba1b to
d8bd80f
Compare
mnahkies
force-pushed
the
mn/test/boost-unit-test-coverage
branch
from
46b988f to
8006639
Compare
mnahkies
added a commit
that referenced
this pull request
Nov 30, 2025
wasn't causing issues yet, but will do once `IRModel` is no longer compatible with `Schema`, split from #386
mnahkies
force-pushed
the
mn/fix/always-extract-request-bodies
branch
from
d8bd80f to
f3e5caa
Compare
Base automatically changed from
mn/fix/always-extract-request-bodies
to
main
December 20, 2025 13:00
mnahkies
force-pushed
the
mn/test/boost-unit-test-coverage
branch
from
8006639 to
8e4a7cd
Compare
mnahkies
commented
Dec 20, 2025
| } | ||
|
|
||
| export interface IRModelBase { | ||
| isIRModel: true |
Owner
Author
There was a problem hiding this comment.
Will probably later change this to be indicated through the type fields, undecided yet
mnahkies
changed the title
mnahkies
commented
Dec 20, 2025
| schema(maybeRef: MaybeIRModel): IRModel { | ||
| if (isRef(maybeRef)) { | ||
| const schema = this.loader.schema(maybeRef) | ||
| return this.schemaNormalizer.isNormalized(schema) |
Owner
Author
There was a problem hiding this comment.
this check is needed because the virtual library currently ends up with a mixture of normalized and raw schemas 🤮 - but it's a pragmatic step forward for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exclusiveMaximum/exclusiveMinimumon numbers being provided asbooleans, for backwards compatibility with earlier json schema definitionssplit theInputclass to make easier to directly testbegin back-filling tests on the IR generation (previously only tested indirectly)