Skip to content

Conversation

caizixian
Copy link
Member

Since we have runtime plan selection support now, this option doesn't make sense anymore.

@caizixian caizixian requested a review from wenyuzhao May 28, 2021 10:57
@qinsoon
Copy link
Member

qinsoon commented May 28, 2021

The features should also be removed from Cargo.toml and the code. Besides, we need to 1) merge Wenyu's changes to the running script to support env vars per build and 2) modify the configs in ci-perf-kit to select plans by env vars.

@caizixian
Copy link
Member Author

The features should also be removed from Cargo.toml and the code. Besides, we need to 1) merge Wenyu's changes to the running script to support env vars per build and 2) modify the configs in ci-perf-kit to select plans by env vars.

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants