Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic summary of benchmark to beginning of readme #845

Closed
wants to merge 3 commits into from

Conversation

qpwo
Copy link
Contributor

@qpwo qpwo commented Feb 18, 2025

it took me a long time to figure out the basics of how this benchmark works, so I think a short description at the beginning of the readme would be helpful.

feel free to edit however you want or close this and do your version on main or whatever

@qpwo qpwo requested a review from a team as a code owner February 18, 2025 21:10
Copy link

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact [email protected].
0 out of 1 committers have signed the MLCommons CLA.
@qpwo
You can retrigger this bot by commenting recheck in this Pull Request

@priyakasimbeg
Copy link
Contributor

Hi Luke, thanks for sending these suggestions in. The MLCommons CLA check on this PR is failing. Could you sign it if you haven't yet? If you have already signed it, could you email [email protected] and ask for help with the CLA check that is failing on this PR.

@priyakasimbeg priyakasimbeg changed the base branch from main to dev March 13, 2025 03:44
@priyakasimbeg
Copy link
Contributor

@fsschneider this PR is stale but I think it is good feedback to maybe include a brief summary describing the methodology of algoperf in the README. wdyt?

@fsschneider
Copy link
Contributor

I agree, this is a good idea. We should do some modifications to the text (i.e. remove the mention of the held-out workloads, to reflect the current set of rules).

I don't want to "steal" Luke's work by creating my own PR using his text as a starting point, but without a signed CLA, we cannot merge. @qpwo could you sign the CLA so that we can properly attribute this contribution to you?

@priyakasimbeg Otherwise, we probably have to close this PR and create or own, right?

@qpwo
Copy link
Contributor Author

qpwo commented Apr 7, 2025

your CLA bot is broken just close and rewrite i dont mind

@qpwo qpwo closed this Apr 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants