Skip to content

MVP implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 9, 2023
Merged

MVP implementation #1

merged 14 commits into from
Nov 9, 2023

Conversation

szg251
Copy link
Collaborator

@szg251 szg251 commented Nov 1, 2023

The MVP includes:

  • type definitions
  • PlutusData conversion traits
  • optional Json conversion traits using LambdaBuffers

@szg251 szg251 marked this pull request as ready for review November 8, 2023 12:01
@szg251 szg251 requested review from bladyjoker and jaredponn and removed request for bladyjoker and jaredponn November 9, 2023 10:43
Copy link
Contributor

@bladyjoker bladyjoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gorgeous! or might one say Gergeous?

@@ -1,4 +1,4 @@
# Plutus Ledger types
# Plutus Ledger API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

flake.nix Outdated
doTest = false;
});

pre-commit.settings.hooks.rustfmt.enable = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All source files need to be checked. I see TOML and Nix, maybe TOML is covered by rustmt

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I'll add these

};
};

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the Hercules CI bit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, so the default setup just works! Marvelous!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly

@szg251 szg251 merged commit 92f02c1 into master Nov 9, 2023
@szg251 szg251 deleted the szg251/init branch November 9, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants