Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hercules inpulse 500 manual #725

Open
wants to merge 62 commits into
base: main
Choose a base branch
from

Conversation

resetreboot
Copy link

@resetreboot resetreboot commented Feb 9, 2025

dj-ak and others added 26 commits January 8, 2022 22:30
Add new launch option (--start-autodj) to documentation
@resetreboot resetreboot force-pushed the hercules-inpulse-500-manual branch from 05675cf to 6595b57 Compare February 9, 2025 17:09
@ronso0
Copy link
Member

ronso0 commented Feb 9, 2025

Thanks for the documentation but we add manuals only for built-in mappings.
Is there a pending mapping PR for the Inpulse 500 at mixxxdj/mixxx that I missed?

@ronso0 ronso0 marked this pull request as draft February 9, 2025 17:14
@resetreboot
Copy link
Author

Hey, yes, I'm about to do the PR, I've been in talks with m0db about this. I thought you first had to submit the manual before the PR with the mapping, but it will be in the next hour up and ready too.

SamWhited and others added 21 commits March 1, 2025 09:04
Remove unwanted diff leftover
tweaking main svg, adding loop svgs (without shift, with shift)
@m0dB
Copy link

m0dB commented Mar 19, 2025

The pre-commit failures should be fixed by resetreboot#4

@ronso0 once the pre-commit is fixed, are you okay with merging this?

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just some fine tuning.

And it would look better if the padmode images were left-aligned like the associated tables. And add a blank line in between img and table.
image

The padmode label font can be smaller so labels fit in the frames.
image

=============================================================== ==========================================
:hwlabel:`SYNC` button Toggle :ref:`Sync Lock <sync-lock>`.
:hwlabel:`SHIFT` + :hwlabel:`SYNC` button Match key to currently playing track.
:hwlabel:`CUE` button Specifies, plays or recalls temporary cue point.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is mapped to cue_default we should link to Using Cue Modes

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, right, @resetreboot ?

=============================================================== ==========================================
:hwlabel:`BROWSER` encoder (turn) Move up/down list.
:hwlabel:`SHIFT` + :hwlabel:`BROWSER` encoder (turn) Move left/right (fold/unfold) list.
:hwlabel:`BROWSER` encoder (press) Switch focus between list and file view.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this mapped to MoveFocus|~BackWard|~Forward?
If yes, it can also focus the Search box and we should mention that, and maybe also may refine the "BROWSER turn" description.

Comment on lines +102 to +104
This mapping turns the FX button into channel selection,
relegating FX to pad mode 7. The LED indicates which
channel is active on the corresponding deck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this does.
Assign decks to fx units?

Copy link

@m0dB m0dB Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It effectively uses (abuses?) the FX buttons as deck selectors, so you can use the controller as a 4 deck controllers.

It is a bit strange that the buttons are labeled FX1,2,3,4, but instead refer to Deck 1,2,3,4 but if you know this, it works very intuitively.

@ronso0
Copy link
Member

ronso0 commented Mar 20, 2025

And please rebase onto 2.5
(unless I missed that some mapping part requires functions from main branch, of course)

@m0dB
Copy link

m0dB commented Mar 21, 2025

@ronso0 the font size issue is weird... it looks fine on macOS, and it surprised me the rendering is so different between linux and macOS...

@resetreboot can you do the rebase on the 2.5 branch of the manual?

@ronso0
Copy link
Member

ronso0 commented Mar 23, 2025

@ronso0 the font size issue is weird... it looks fine on macOS, and it surprised me the rendering is so different between linux and macOS...

I don't know where that stems from, maybe a macOS font?
One way to fix it is font -> path conversion, once the strings are fixed (which they are for controller labels).

@resetreboot
Copy link
Author

Original branch rebased off 2.5! Sorry for the delay, guys, things been a bit busy over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.